Feature/split off client#2
Conversation
… shared components, update development environment configurations and CI/CD workflows, and add architectural design documentation.
Summary of ChangesHello @Zalfsten, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a significant architectural refactoring by decoupling the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR performs a major architectural refactoring by extracting the API, API client, and shared components from this repository into a separate repository. The remaining code focuses solely on the SQL-to-ARC conversion functionality.
Changes:
- Removes the middleware API, API client, and shared packages from the workspace
- Converts sql_to_arc to depend on external Git repository for api_client and shared packages
- Removes all Helm charts, Docker configurations for API, and related documentation
- Simplifies the development environment to focus only on sql_to_arc
- Removes extensive test suites for the removed components
Reviewed changes
Copilot reviewed 107 out of 110 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Removes workspace members and dependencies for api, api_client, shared, and tools packages |
| middleware/sql_to_arc/pyproject.toml | Changes dependencies to reference external Git repository instead of workspace packages |
| docker/Dockerfile.sql_to_arc | Updates build process for standalone sql_to_arc, adds git dependency |
| docker/Dockerfile.api | Complete removal of API Docker configuration |
| dev_environment/* | Simplifies to external API setup, removes local API infrastructure |
| .github/workflows/* | Updates CI to build only sql_to_arc, removes API and Helm chart workflows |
| Multiple test/code files | Removes all API, shared, and api_client source code and tests |
| Documentation files | Removes middleware API and Helm chart documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the repository to split off the sql_to_arc client from the larger middleware monorepo. This involves removing the middleware-api, api-client, shared, and other related components, and updating the configuration and build processes to treat them as external dependencies. The changes are extensive but seem to be consistent with the goal of creating a standalone client. I've identified a few areas for improvement, mainly concerning a potentially breaking git dependency in pyproject.toml and some confusion in the devcontainer configuration.
…for api_client and shared
No description provided.